Cool!
For me, their positives outweigh their negatives.
They are the only gun rights lobby to have access to the white house. They are the 800 lb gorilla in the room, and frankly, I want to feed that gorilla as much as I can afford because he is in my corner.
I have joined or will join other groups, but I gave NRA memberships as stocking stuffers this year to my family and a few friends. I felt that this was a great way to add a few members, and who knows, they might sign up a few people this Christmas.